Simple block chip inverse #1300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accessibility report ❌ 6 problems detectedcommunity-blocks--block-row (1 violations)community-blocks--block-simple (1 violations)community-blocks--block-information (1 violations)community-blocks--block-highlighted-value (1 violations)community-blocks--block-value (1 violations)community-blocks--block-progress (1 violations)ℹ️ You can run this locally by executing |
|
Screenshot tests report ❌ chip / chip-multiple-selection-inverse-true-badge-2
❌ chip / chip-multiple-selection-inverse-true-badge-undefined
❌ chip / chip-single-selection-inverse-true-badge-2
❌ chip / chip-single-selection-inverse-true-badge-undefined
❌ private-skin-components / components-in-blau-inverse-2
❌ private-skin-components / components-in-blau-inverse-and-dark-mode-2
❌ private-skin-components / components-in-movistar-inverse-2
❌ private-skin-components / components-in-movistar-inverse-and-dark-mode-2
❌ private-skin-components / components-in-o-2-inverse-2
❌ private-skin-components / components-in-o-2-inverse-and-dark-mode-2
❌ private-skin-components / components-in-o-2-new-inverse-2
❌ private-skin-components / components-in-o-2-new-inverse-and-dark-mode-2
❌ private-skin-components / components-in-telefonica-inverse-2
❌ private-skin-components / components-in-telefonica-inverse-and-dark-mode-2
❌ private-skin-components / components-in-tu-inverse-2
❌ private-skin-components / components-in-tu-inverse-and-dark-mode-2
❌ private-skin-components / components-in-vivo-new-inverse-2
❌ private-skin-components / components-in-vivo-new-inverse-and-dark-mode-2
❌ theme-variant / theme-variant-in-dark-mode-inverse
❌ theme-variant / theme-variant-inverse
|
paulo-asilva
changed the title
paulo-asilva
changed the title
paulo-asilva
force-pushed
the
simple-block-chip-inverse
branch
from
4229911 to
1c270d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OBVIVO-2814 (Simple Block): the label property was added to the simple block, and some adjustments were also included using the Inline component to align the position in the component.
OBVIVO-2618 (Chip): including the use of the inverse token (vars.colors.neutralLow) along with some validations to add it if inverse is true. There is also a small change in the text and icon on the chip to make it readable when using inverse.