feat: add label property to simple-block #1301
Conversation
|
Accessibility report ℹ️ You can run this locally by executing |
|
Screenshot tests report ❌ chip / chip-multiple-selection-inverse-true-badge-2-2
❌ chip / chip-multiple-selection-inverse-true-badge-undefined-2
|
|
Size stats
|
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit fa4bbc6. |
There was a problem hiding this comment.
chip is broken in inverse.
I think there is a misunderstanding about the chip task.
You need to include a logic to make the chip colors change when you use active prop with onPress/href/to
For example: <Chip href="#" active /> then, the chip is colored like in specs
https://www.figma.com/design/512a5Ke4EldL0GYffCXGCJ/%F0%9F%94%B8-Chips-Specs?node-id=3876-2059&t=JVUcLR4t1jdpQr7T-4
You can check what tokens need to use in Tokens artboard
For inverse contexts, the chips are visually the same as current implementation
| </Text2> | ||
| </Inline> | ||
| <div className={styles.rightContent}> | ||
| <Text2 regular color={vars.colors.brand}> |
There was a problem hiding this comment.
| <Text2 regular color={vars.colors.brand}> | |
| <Text2 regular color={vars.colors.textBrand}> |
|
I don't really like the idea of having 1 only PR for making two different things (when one of the changes is in a core component like chips) If we keep with this idea, I would recommend changing the PR title to include chip changes |
|
agree with @yceballost, please make 2 different PRs |
OBVIVO-2814 (Simple Block): the label property was added to the simple block, and some adjustments were also included using the Inline component to align the position in the component.
OBVIVO-2618 (Chip): including the use of the inverse token (vars.colors.neutralLow) along with some validations to add it if inverse is true. There is also a small change in the text and icon on the chip to make it readable when using inverse.