Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Chip): change background color on hover/active #1302

Merged
merged 9 commits into from
Dec 19, 2024
Merged

feat(Chip): change background color on hover/active #1302

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eda44ee
feat(skin): update design tokens
atabel Dec 10, 2024
d3f332e
update snapshots
atabel Dec 10, 2024
23e82e0
Merge branch 'master' into import-design-tokens-production
atabel Dec 18, 2024
9f707a4
added overlay for hover/active in Chips
atabel Dec 18, 2024
b4f7b65
update screenshots
atabel Dec 18, 2024
27ee630
remove text color change on hover
atabel Dec 18, 2024
8dabbd4
add :active state to any interactive chip
atabel Dec 19, 2024
b0764cb
fix overlay width
atabel Dec 19, 2024
50a0a1a
update screenshots
atabel Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...er-detail-layout-screenshot-test-tsx-master-detail-layout-in-desktop-2-snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions src/skins/blau.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ export const getBlauSkin: GetKnownSkin = () => {
background: palette.white,
backgroundContainer: palette.white,
backgroundContainerError: palette.blauRed10,
backgroundContainerHover: applyAlpha(palette.blauBluePrimary, 0.03),
backgroundContainerPressed: applyAlpha(palette.blauBluePrimary, 0.05),
backgroundContainerHover: applyAlpha(palette.blauBlueSecondary, 0.05),
backgroundContainerPressed: applyAlpha(palette.blauBlueSecondary, 0.08),
backgroundContainerBrand: palette.blauBluePrimary,
backgroundContainerBrandHover: applyAlpha(palette.darkModeBlack, 0.2),
backgroundContainerBrandPressed: applyAlpha(palette.darkModeBlack, 0.4),
Expand Down Expand Up @@ -187,8 +187,8 @@ export const getBlauSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.darkModeBlack,
backgroundContainer: palette.darkModeGrey,
backgroundContainerError: palette.darkModeGrey,
backgroundContainerHover: applyAlpha(palette.white, 0.03),
backgroundContainerPressed: applyAlpha(palette.white, 0.05),
backgroundContainerHover: applyAlpha(palette.white, 0.05),
backgroundContainerPressed: applyAlpha(palette.white, 0.08),
backgroundContainerBrand: palette.darkModeGrey,
backgroundContainerBrandHover: applyAlpha(palette.white, 0.03),
backgroundContainerBrandPressed: applyAlpha(palette.white, 0.05),
Expand Down
8 changes: 4 additions & 4 deletions src/skins/movistar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ export const getMovistarSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.movistarBlueDark,
backgroundContainer: palette.white,
backgroundContainerError: palette.pepper10,
backgroundContainerHover: applyAlpha(palette.black, 0.03),
backgroundContainerPressed: applyAlpha(palette.black, 0.05),
backgroundContainerHover: applyAlpha(palette.black, 0.05),
backgroundContainerPressed: applyAlpha(palette.black, 0.08),
backgroundContainerBrand: palette.movistarBlue,
backgroundContainerBrandHover: applyAlpha(palette.black, 0.1),
backgroundContainerBrandPressed: applyAlpha(palette.black, 0.2),
Expand Down Expand Up @@ -205,8 +205,8 @@ export const getMovistarSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.darkModeBlack,
backgroundContainer: palette.darkModeGrey,
backgroundContainerError: palette.darkModeGrey,
backgroundContainerHover: applyAlpha(palette.white, 0.03),
backgroundContainerPressed: applyAlpha(palette.white, 0.05),
backgroundContainerHover: applyAlpha(palette.white, 0.05),
backgroundContainerPressed: applyAlpha(palette.white, 0.08),
backgroundContainerBrand: palette.darkModeGrey,
backgroundContainerBrandHover: applyAlpha(palette.white, 0.03),
backgroundContainerBrandPressed: applyAlpha(palette.white, 0.05),
Expand Down
8 changes: 4 additions & 4 deletions src/skins/o2-new.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ export const getO2NewSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.beyondBlue,
backgroundContainer: palette.white,
backgroundContainerError: palette.o2Red10,
backgroundContainerHover: applyAlpha(palette.darkModeBlack, 0.03),
backgroundContainerPressed: applyAlpha(palette.darkModeBlack, 0.05),
backgroundContainerHover: applyAlpha(palette.darkModeBlack, 0.05),
backgroundContainerPressed: applyAlpha(palette.darkModeBlack, 0.08),
backgroundContainerBrand: `linear-gradient(180deg, ${palette.darkBlue} 0%, ${palette.beyondBlue} 64%, ${palette.beyondBlue45} 100%)`,
backgroundContainerBrandHover: applyAlpha(palette.darkModeBlack, 0.2),
backgroundContainerBrandPressed: applyAlpha(palette.darkModeBlack, 0.4),
Expand Down Expand Up @@ -195,8 +195,8 @@ export const getO2NewSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.darkModeBlack,
backgroundContainer: palette.darkModeGrey,
backgroundContainerError: palette.darkModeGrey,
backgroundContainerHover: applyAlpha(palette.white, 0.03),
backgroundContainerPressed: applyAlpha(palette.white, 0.05),
backgroundContainerHover: applyAlpha(palette.white, 0.05),
backgroundContainerPressed: applyAlpha(palette.white, 0.08),
backgroundContainerBrand: palette.darkModeGrey,
backgroundContainerBrandHover: applyAlpha(palette.white, 0.03),
backgroundContainerBrandPressed: applyAlpha(palette.white, 0.05),
Expand Down
8 changes: 4 additions & 4 deletions src/skins/o2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ export const getO2Skin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.o2BluePrimary,
backgroundContainer: palette.white,
backgroundContainerError: palette.pepper10,
backgroundContainerHover: applyAlpha(palette.darkModeBlack, 0.03),
backgroundContainerPressed: applyAlpha(palette.darkModeBlack, 0.05),
backgroundContainerHover: applyAlpha(palette.darkModeBlack, 0.05),
backgroundContainerPressed: applyAlpha(palette.darkModeBlack, 0.08),
backgroundContainerBrand: palette.o2BluePrimary,
backgroundContainerBrandHover: applyAlpha(palette.darkModeBlack, 0.2),
backgroundContainerBrandPressed: applyAlpha(palette.darkModeBlack, 0.4),
Expand Down Expand Up @@ -192,8 +192,8 @@ export const getO2Skin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.darkModeBlack,
backgroundContainer: palette.darkModeGrey,
backgroundContainerError: palette.darkModeGrey,
backgroundContainerHover: applyAlpha(palette.white, 0.03),
backgroundContainerPressed: applyAlpha(palette.white, 0.05),
backgroundContainerHover: applyAlpha(palette.white, 0.05),
backgroundContainerPressed: applyAlpha(palette.white, 0.08),
backgroundContainerBrand: palette.darkModeGrey,
backgroundContainerBrandHover: applyAlpha(palette.white, 0.03),
backgroundContainerBrandPressed: applyAlpha(palette.white, 0.05),
Expand Down
8 changes: 4 additions & 4 deletions src/skins/telefonica.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ export const getTelefonicaSkin: GetKnownSkin = () => {
background: palette.white,
backgroundContainer: palette.white,
backgroundContainerError: palette.coral10,
backgroundContainerHover: applyAlpha(palette.telefonicaBlue, 0.03),
backgroundContainerPressed: applyAlpha(palette.telefonicaBlue, 0.05),
backgroundContainerHover: applyAlpha(palette.telefonicaBlue70, 0.05),
backgroundContainerPressed: applyAlpha(palette.telefonicaBlue70, 0.08),
backgroundContainerBrand: palette.telefonicaBlue,
backgroundContainerBrandHover: applyAlpha(palette.darkModeBlack, 0.2),
backgroundContainerBrandPressed: applyAlpha(palette.darkModeBlack, 0.4),
Expand Down Expand Up @@ -186,8 +186,8 @@ export const getTelefonicaSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.darkModeBlack,
backgroundContainer: palette.darkModeGrey,
backgroundContainerError: palette.darkModeGrey,
backgroundContainerHover: applyAlpha(palette.white, 0.03),
backgroundContainerPressed: applyAlpha(palette.white, 0.05),
backgroundContainerHover: applyAlpha(palette.white, 0.05),
backgroundContainerPressed: applyAlpha(palette.white, 0.08),
backgroundContainerBrand: palette.darkModeGrey,
backgroundContainerBrandHover: applyAlpha(palette.white, 0.03),
backgroundContainerBrandPressed: applyAlpha(palette.white, 0.05),
Expand Down
8 changes: 4 additions & 4 deletions src/skins/tu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ export const getTuSkin: GetKnownSkin = () => {
background: palette.white,
backgroundContainer: palette.white,
backgroundContainerError: palette.red10,
backgroundContainerHover: applyAlpha(palette.grey9, 0.03),
backgroundContainerPressed: applyAlpha(palette.grey9, 0.05),
backgroundContainerHover: applyAlpha(palette.grey9, 0.05),
backgroundContainerPressed: applyAlpha(palette.grey9, 0.08),
backgroundContainerBrand: palette.primary,
backgroundContainerBrandHover: applyAlpha(palette.grey9, 0.2),
backgroundContainerBrandPressed: applyAlpha(palette.grey9, 0.4),
Expand Down Expand Up @@ -190,8 +190,8 @@ export const getTuSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.darkModeBlack,
backgroundContainer: palette.darkModeGrey,
backgroundContainerError: palette.darkModeGrey,
backgroundContainerHover: applyAlpha(palette.white, 0.03),
backgroundContainerPressed: applyAlpha(palette.white, 0.05),
backgroundContainerHover: applyAlpha(palette.white, 0.05),
backgroundContainerPressed: applyAlpha(palette.white, 0.08),
backgroundContainerBrand: palette.darkModeGrey,
backgroundContainerBrandHover: applyAlpha(palette.white, 0.03),
backgroundContainerBrandPressed: applyAlpha(palette.white, 0.05),
Expand Down
8 changes: 4 additions & 4 deletions src/skins/vivo-new.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ export const getVivoNewSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.vivoPurpleLight80,
backgroundContainer: palette.white,
backgroundContainerError: palette.pepperLight10,
backgroundContainerHover: applyAlpha(palette.darkModeBlack, 0.03),
backgroundContainerPressed: applyAlpha(palette.darkModeBlack, 0.05),
backgroundContainerHover: applyAlpha(palette.darkModeBlack, 0.05),
backgroundContainerPressed: applyAlpha(palette.darkModeBlack, 0.08),
backgroundContainerBrand: palette.vivoPurple,
backgroundContainerBrandHover: applyAlpha(palette.darkModeBlack, 0.2),
backgroundContainerBrandPressed: applyAlpha(palette.darkModeBlack, 0.4),
Expand Down Expand Up @@ -185,8 +185,8 @@ export const getVivoNewSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.darkModeBlack,
backgroundContainer: palette.darkModeGrey,
backgroundContainerError: palette.darkModeGrey,
backgroundContainerHover: applyAlpha(palette.white, 0.03),
backgroundContainerPressed: applyAlpha(palette.white, 0.05),
backgroundContainerHover: applyAlpha(palette.white, 0.05),
backgroundContainerPressed: applyAlpha(palette.white, 0.08),
backgroundContainerBrand: palette.darkModeGrey,
backgroundContainerBrandHover: applyAlpha(palette.white, 0.03),
backgroundContainerBrandPressed: applyAlpha(palette.white, 0.05),
Expand Down
8 changes: 4 additions & 4 deletions src/skins/vivo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ export const getVivoSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.vivoPurple,
backgroundContainer: palette.white,
backgroundContainerError: palette.pepperLight10,
backgroundContainerHover: applyAlpha(palette.darkModeBlack, 0.03),
backgroundContainerPressed: applyAlpha(palette.darkModeBlack, 0.05),
backgroundContainerHover: applyAlpha(palette.darkModeBlack, 0.05),
backgroundContainerPressed: applyAlpha(palette.darkModeBlack, 0.08),
backgroundContainerBrand: palette.vivoPurple,
backgroundContainerBrandHover: applyAlpha(palette.darkModeBlack, 0.2),
backgroundContainerBrandPressed: applyAlpha(palette.darkModeBlack, 0.4),
Expand Down Expand Up @@ -185,8 +185,8 @@ export const getVivoSkin: GetKnownSkin = () => {
backgroundBrandSecondary: palette.darkModeBlack,
backgroundContainer: palette.darkModeGrey,
backgroundContainerError: palette.darkModeGrey,
backgroundContainerHover: applyAlpha(palette.white, 0.03),
backgroundContainerPressed: applyAlpha(palette.white, 0.05),
backgroundContainerHover: applyAlpha(palette.white, 0.05),
backgroundContainerPressed: applyAlpha(palette.white, 0.08),
backgroundContainerBrand: palette.darkModeGrey,
backgroundContainerBrandHover: applyAlpha(palette.white, 0.03),
backgroundContainerBrandPressed: applyAlpha(palette.white, 0.05),
Expand Down
Loading