feat(Sheet): multiline support for description #896
Conversation
|
Size stats
|
atabel
requested review from
yceballost,
pladaria,
Marcosld and
marcoskolodny
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit abcdb6f. |
src/sheet-root.tsx
Outdated
| @@ -105,7 +105,8 @@ const showRadioListNativeSheet = ({ | |||
| (nativeSheetImplementation as NativeSheetImplementation)({ | |||
| title, | |||
| subtitle, | |||
| description, | |||
| // TODO: add multiline support to native sheet | |||
| description: Array.isArray(description) ? description.join('\n') : description, | |||
There was a problem hiding this comment.
perhaps, you should join with two line breaks, to simulate different paragraphs
There was a problem hiding this comment.
also note that:
[].join('\n') returns empty string, but in this case we probably want to set an undefined description.
There was a problem hiding this comment.
I want to do some tests with the native implementation and see what happens with \n and \n\n
There was a problem hiding this comment.
Tested. It seems to work quite fine with the double \n\n:
src/__stories__/sheet-story.tsx
Outdated
| title, | ||
| subtitle, | ||
| description, | ||
| multilineDescription, |
There was a problem hiding this comment.
multiParagraph name maybe fit better? 🤔
multilineDescription could be this:
# [14.24.0](v14.23.1...v14.24.0) (2023-09-28) ### Features * **Sheet:** multiline support for description ([#896](#896)) ([0c328bf](0c328bf))
|
🎉 This PR is included in version 14.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jira: WEB-1559