fix(Header): don't render title when not provided #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit de893b1. |
|
Screenshot tests report ✔️ All passing |
marcoskolodny
approved these changes
Sep 25, 2023
tuentisre
pushed a commit
that referenced
this pull request
Sep 25, 2023
## [14.23.1](v14.23.0...v14.23.1) (2023-09-25) ### Bug Fixes * **Header:** don't render title when not provided ([#898](#898)) ([b760243](b760243)) * **Snackbar:** z-index conflict with FixedFooterLayout ([#897](#897)) ([0d86e02](0d86e02)) * **SuccessFeedback:** Vivo-new icon size change ([#895](#895)) ([71c5297](71c5297))
|
🎉 This PR is included in version 14.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken because of this change:
https://github.com/Telefonica/mistica-web/pull/880/files#diff-e751a29b3f34d283e9d54e96a51d36af37fbbaa38f8fdb994b3e5fa920065ea2
This causes this issue in webapp:
