feat(Accordion): create Accordion and BoxedAccordion components #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 80000db. |
marcoskolodny
commented
Sep 29, 2023
| @@ -179,7 +179,7 @@ export const navigationBarContentRight = style({ | |||
| display: 'flex', | |||
| flex: 1, | |||
| alignItems: 'center', | |||
| justifyContent: 'end', | |||
| justifyContent: 'flex-end', | |||
There was a problem hiding this comment.
Unrelated to this task. This was causing a warning from Vite when executing yarn build
marcoskolodny
commented
Sep 29, 2023
yceballost
previously requested changes
Oct 2, 2023
...apshots__/accordion-screenshot-test-tsx-accordion-inverse-false-single-open-false-2-snap.png
Outdated
Show resolved
Hide resolved
pladaria
reviewed
Oct 2, 2023
...apshots__/accordion-screenshot-test-tsx-accordion-inverse-false-single-open-false-2-snap.png
Outdated
Show resolved
Hide resolved
yceballost
approved these changes
Oct 3, 2023
marcoskolodny
changed the title
atabel
reviewed
Oct 5, 2023
atabel
approved these changes
Oct 10, 2023
Closed
atabel
pushed a commit
that referenced
this pull request
Oct 16, 2023
* first POC * fix chevron styling and overflow bug * update accordions * unmount panel on close and use CSSTransition * add singleOpen and update opened items internal logic * add unit tests and playroom snippets * add accordion stories * add screenshot tests * resolve comments and remove GroupedAccordion * resolve comments * fix accordion test * use waitFor in accordion test * remove unnecesary async in accordion tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* feat(OtpField): new component * complete component features * add labels for individual inputs. Prevent multiple calls for otp sms * usability fixes * acceptance tests * snippets * add web otp api url comment * placeholder for hideCode case * fixes from CR * prevent focusing next input when a non-number is typed * prevent glitches reported in CR * rename to PinField * increase test timeout in sheet-test * allow to disable sms read with a prop * fix input background when focused * feat(skin): update design tokens (#893) * feat(skin): update design tokens * reverse movistar-legacy --------- Co-authored-by: yceballost <[email protected]> Co-authored-by: Abel Toledano <[email protected]> * chore(release): 14.25.0 [skip ci] # [14.25.0](v14.24.1...v14.25.0) (2023-10-09) ### Features * **skin:** update design tokens ([#893](#893)) ([736a655](736a655)) * **Slider:** new component ([#867](#867)) ([4e02a0d](4e02a0d)) * feat(Menu): fix component styles and add MenuItem/MenuSection (#892) * deprecate Menu and rename it to DropdownMenu * multiple fixes in menu component * update styles, add menu items and section components * revert name change and add check to menuItem * fix error, update screenshots and add playroom snippet * fix close menu animations * add aria props to menu items * add keyboard interactivity * fix logic for keyboard navigation * resolve comments * update screenshots * updates in component interaction * fix test * fix playroom snippet * udpate menu story and screenshot test * remove obsolete tabIndex logic in checkbox * avoid user pressing an option multiple times while menu is closing * rename focusable to focused in variables * fix aria label prop name * add focus to target on menu close * remove close function call in story * update transitions and cleanup code (#901) * resolve comments and fix overlay hidden children * resolve comments and update screenshots * add accessibility props to target * fix typo * use item indices instead of labels for focusing logic * fix aria-expanded * fix accesibility issue in mistica lab story * code cleanup * remove hack for menu container role * chore(SonarQube): Setup SonarQube (#903) * WEB-1570 configure sonarqube * WEB-1570 remove and ignore .scannerwork * WEB-1570 setup gh workflow * WEB-1570 setup gh workflow * WEB-1570 setup gh workflow * WEB-1570 setup gh workflow * WEB-1570 setup gh workflow * WEB-1570 revert workflow * WEB-1570 add comment --------- Co-authored-by: Pedro Ladaria <[email protected]> * feat(Accordion): create Accordion and BoxedAccordion components (#900) * first POC * fix chevron styling and overflow bug * update accordions * unmount panel on close and use CSSTransition * add singleOpen and update opened items internal logic * add unit tests and playroom snippets * add accordion stories * add screenshot tests * resolve comments and remove GroupedAccordion * resolve comments * fix accordion test * use waitFor in accordion test * remove unnecesary async in accordion tests * fix(Video, DisplayMediaCard, PosterCard): show fallback on empty src (#910) * show fallback on empty src for video/cards * remove console log and update tests * fix screenshot tests * remove placeholder --------- Co-authored-by: Flow <[email protected]> Co-authored-by: yceballost <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Marcos Kolodny <[email protected]> Co-authored-by: Pedro Ladaria <[email protected]> Co-authored-by: Pedro Ladaria <[email protected]>
tuentisre
pushed a commit
that referenced
this pull request
Oct 18, 2023
# [14.26.0](v14.25.0...v14.26.0) (2023-10-18) ### Bug Fixes * **Carousel:** cards bottom border being partially cut in iOS ([#920](#920)) ([754acc6](754acc6)) * **Video, DisplayMediaCard, PosterCard:** show fallback on empty src ([#910](#910)) ([4e366d3](4e366d3)) ### Features * **Accordion:** create Accordion and BoxedAccordion components ([#900](#900)) ([7062a43](7062a43)) * **Icons:** use icon keywords from mistica design in catalog story ([#914](#914)) ([286e385](286e385)) * **Menu:** fix component styles and add MenuItem/MenuSection ([#892](#892)) ([d7a7e30](d7a7e30)), closes [#901](#901) * **Mobile:** add interaction states when pressing touchable elements ([#912](#912)) ([dbd8ac0](dbd8ac0)) * **OverscrollColor, Storybook:** overscroll alternative variant and storybook default platform detection ([#919](#919)) ([77d9b45](77d9b45)) * **PinField:** new component ([#902](#902)) ([484dbc7](484dbc7)), closes [#893](#893) * **ProgressBarStepped:** create component ([#905](#905)) ([25ed4eb](25ed4eb))
|
🎉 This PR is included in version 14.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Link
Specs: Link