Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Playroom): add icon keywords to playroom scope #918

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

marcoskolodny
Copy link
Contributor

No description provided.

@marcoskolodny marcoskolodny requested a review from atabel October 17, 2023 10:03
@@ -381,15 +381,15 @@ const iconKeywords: {[key: string]: Array<string>} = {
],
audio: ['sound', 'audio signal', 'soundwave', 'sonido', 'sinal de áudio', 'Ton'],
aura: ['assistant', 'virtual', 'helper', 'aura', 'aura virtual', 'Helfer'],
'authentication-failure': [
'autentication-failure': [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change. It's just an update in Mistica design repo

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's a typo, isn't it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we added to 15.0.0 major version to solve this typo in some icons and avoid breaking changes now
#626

@github-actions
Copy link

Size stats

master this branch diff
Total JS 9.51 MB 9.51 MB 0 B
JS without icons 1 MB 1 MB 0 B
Lib overhead 127 kB 127 kB 0 B
Lib overhead (gzip) 32.5 kB 32.5 kB 0 B

@github-actions
Copy link

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-9h9ynklor-tuentisre.vercel.app

Built with commit ed44617.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@atabel atabel enabled auto-merge October 17, 2023 10:10
@atabel atabel added this pull request to the merge queue Oct 17, 2023
Merged via the queue into master with commit 89ea4ff Oct 17, 2023
10 checks passed
@atabel atabel deleted the playroom-icon-keywords branch October 17, 2023 10:25
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 14.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants