fix: partial replacement for string with length #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarmor
commented
Mar 21, 2024
| seed, length = param[1:-1].split('_ARRAY_WITH_LENGTH_') | ||
| new_param = list(seeds[seed] for x in range(int(length))) | ||
| param_replaced = True | ||
| elif 'JSON_WITH_LENGTH_' in param: | ||
| length = int(param[1:-1].split('JSON_WITH_LENGTH_')[1]) | ||
| new_param = dict((str(x), str(x)) for x in range(length)) | ||
| param_replaced = True | ||
| elif any(x in param for x in ['STRING_WITH_LENGTH_', 'INTEGER_WITH_LENGTH_']): | ||
| seeds = {'STRING': 'a', 'INTEGER': '1'} | ||
| # The chain to be generated can be just a part of param |
There was a problem hiding this comment.
this could not be because we are inside an if that checks that param starts and ends with []
cgarmor
force-pushed
the
fix_partial_replacement_string_with_length
branch
from
704dabc to
143bb31
Compare
cgarmor
force-pushed
the
fix_partial_replacement_string_with_length
branch
from
143bb31 to
12edfd3
Compare
|
Code Climate has analyzed commit 12edfd3 and detected 0 issues on this pull request. View more on Code Climate. |
rgonalo
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from the dataset code it seems that support for [STRING_WITH_LENGTH_NN] inside a longer string was inteded to be supported, but the implementation does not work. This is a fix as it might be a useful feature (e.g.: for composing parameters that require a determined substring + having a given length)