feat: stop playwright when driver is closed #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardogarfe
approved these changes
Jun 11, 2024
jruizg23
approved these changes
Jun 11, 2024
jruizg23
pushed a commit
that referenced
this pull request
Jul 15, 2024
jruizg23
added a commit
that referenced
this pull request
Jul 15, 2024
* NOV-244340: expression for selecting in an array for a context storage (#388) * chore: base code for selecting in an array using expresions like a.[key='value'].b * fix: previous unitary tests with the new code * test: add positive unitary tests for the new feature * test: add negative unitary tests * doc: updated methods docstring * doc: updated changelog * fix: flake8 format for unitary testing * fix: flake8 format for dataset module * chore: adapt code to codeclimate bot stupidity * test: add unitary test for invalid list structure * fix: upgrade Faker version to 25.9 (#394) * fix: upgrade Faker version to 25.9 * fix Firefox unittests * bug(QAWTO-212): fix result for action before the feature error with background (#397) * bug(QAWTO-212): fix action before the feature with background output with error * fix(QAWTO-212): fix flake8 linter messages * fix(QAWTO-212): move behave import to selected function * docs(QAWTO-212): update changelog * feat: add initial integration of playwright (#387) * feat: add initial integration of playwright * avoid error in after_scenario * feat: reuse toolium driver and pageobjects for playwright tests (#389) * chore: include playwright module on setup (#391) * chore: include playwright module on setup * feat: playwright enable headless config (#392) * feat: stop playwright when driver is closed (#393) * playwright start by browser * avoid duplications for ConfigDriver instance * fix lint --------- Co-authored-by: robertomier <[email protected]> Co-authored-by: Rubén González Alonso <[email protected]> Co-authored-by: Ricardo García Fernández <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.