Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version incoherence crash #36

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

jdelga
Copy link
Member

@jdelga jdelga commented Jan 18, 2024

Fix a crash when the app has a compose:material version higher than the tweaks library.

It can be tested using a higher version in the module app than in library

                                           java.lang.NoClassDefFoundError: Failed resolution of: Landroidx/compose/material/TouchTargetKt;
                                           	at com.telefonica.tweaks.ui.TweakComponentsKt$EditableBooleanTweakEntryBody$2.invoke(TweakComponents.kt:326)
                                           	at com.telefonica.tweaks.ui.TweakComponentsKt$EditableBooleanTweakEntryBody$2.invoke(TweakComponents.kt:325)
                                           	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:116)
                                           	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)
                                           	at com.telefonica.tweaks.ui.TweakComponentsKt.TweakRow(TweakComponents.kt:453)
                                           	at com.telefonica.tweaks.ui.TweakComponentsKt.EditableBooleanTweakEntryBody(TweakComponents.kt:317)
                                           	at com.telefonica.tweaks.ui.TweakComponentsKt$TweakGroupBody$1.invoke(TweakComponents.kt:179)
                                           	at com.telefonica.tweaks.ui.TweakComponentsKt$TweakGroupBody$1.invoke(TweakComponents.kt:160)
                                           	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:107)
                                           	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:34)

Before:

tweaks_crash.webm

After:

tweaks_crash_fixed.webm

@jdelga jdelga requested review from a team, dagonco, DevPabloGarcia and pmartinbTEF and removed request for a team and dagonco January 18, 2024 16:49
app/build.gradle Fixed Show fixed Hide fixed
app/build.gradle Outdated Show resolved Hide resolved
Copy link
Contributor

@pmartinbTEF pmartinbTEF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

app/build.gradle Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@pmartinbTEF pmartinbTEF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link

@DevPabloGarcia DevPabloGarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@jdelga jdelga merged commit cbc2b0a into main Jan 19, 2024
3 checks passed
@jdelga jdelga deleted the jdelga/fix_version_incoherence_crash branch January 19, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants