Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BOM #41

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Remove BOM #41

merged 2 commits into from
Apr 26, 2024

Conversation

yamal-alm
Copy link
Contributor

🥅 What's the goal?

Same problem described in this PR Telefonica/mistica-android#230

🚧 How do we do it?

Do not use Compose Bom and use explicit version of each compose dependency. Fortunately it is the same for every of it. I used 1.6.6 version, the one corresponding to "2024.04.01" BOM (defined in this mappings table https://developer.android.com/develop/ui/compose/bom/bom-mapping)

📘 Documentation changes?

  • No docs to update nor create

🧪 How can I test this?

  • Manually tested, everything works as before

@yamal-alm yamal-alm requested review from jdelga, a team and DevPabloGarcia and removed request for a team April 25, 2024 12:05
app/build.gradle Outdated Show resolved Hide resolved
@yamal-alm yamal-alm requested a review from jdelga April 25, 2024 13:54
Copy link

@DevPabloGarcia DevPabloGarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@yamal-alm yamal-alm merged commit e1f4c1f into main Apr 26, 2024
3 checks passed
@yamal-alm yamal-alm deleted the remove-bom branch April 26, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants