Fix Notification Request popup #753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original logic considered a denial before 3 seconds to be "accidental". Many users can read the popup and decide long before then, just to be asked again a day later. I think it should be half a second (500), but 1 second is much better than 3 This should fix bug Telegram-FOSS-Team#752 , although the user was incorrect in their theory, they were just hitting it too quickly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original logic considered a denial before 3 seconds to be "accidental". Many users can read the popup and decide long before then, just to be asked again a day later.
I think it should be half a second (500), but 1 second is much better than 3
This should fix bug #752 , although the user was incorrect in their theory, they were just hitting it too quickly