Update DemandActivityConstraint #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes a small update to the DemandActivityConstraint by skipping it for any demand that has fewer than 2 technologies that directly meet it. (This is because the constraint is redundant if only one tech meets it).
data_files/temoa_schema.sql
Outdated
There was a problem hiding this comment.
The schema update is welcomed with the addition of the new tech_rps constraint and would ideally be a part of a separate commit. If this is not feasible, would it be possible to add a note in your commit message that addresses this addition?
There was a problem hiding this comment.
Ah, good eye. That's an oversight on my end. I'll update the PR accordingly. Thanks!
SutubraResearch
force-pushed
the
v3.0.0-dev
branch
from
907205c
to
21369f3
Compare
jeff-ws
pushed a commit
to jeff-ws/temoa
that referenced
this pull request
Feb 22, 2024
This commit makes a small update to the DemandActivityConstraint by skipping it for any demand that has fewer than 2 technologies that directly meet it. (This is because the constraint is redundant if only one tech meets it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes a small update to the DemandActivityConstraint by skipping it for any demand that has fewer than 2 technologies that directly meet it. (This is because the constraint is redundant if only one tech meets it).