Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos in Neow Rewards #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix typos in Neow Rewards #73

wants to merge 2 commits into from

Conversation

ntseng
Copy link

@ntseng ntseng commented Jul 24, 2024 •
edited
Loading

  • add space between desciption and character class
  • remove period from descriptions in English and German (where they were inconsistent)
  • added space between parenthetical player attribution to allow color code to parse
  • add missing space before bracket to in German localization
  • add spaces to fix character name coloring in Japanese and Simplified Chinese localizations

Before:
image

After:
image

@ntseng
fix typos in Neow Rewards
7be7ce7 
- add space between desciption and character class
- remove period at end of description (other rewards don't end in period)
- added space between parenthetical player attribution to allow color code to parse
@ntseng
additional neow reward typo fixes
fe082a8 
- move space from description generation to localization
- remove period from descriptions in English and German (where they were inconsistent)
- add missing space before bracket to in German localization
- add spaces to fix character name coloring in Japanese and Simplified Chinese localizations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ntseng