Skip to content

Commit

Permalink
Add TODO about FastConfig naming needing to be updated
Browse files Browse the repository at this point in the history
As discussed here:
microsoft#6024 (comment)
  • Loading branch information
Ten0 committed Jan 12, 2024
1 parent c7e9d2e commit 993f8f5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/c_api.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2113,8 +2113,8 @@ int LGBM_BoosterCalcNumPredict(BoosterHandle handle,
API_END();
}



// TODO in future versions of LightGBM, public API named around `FastConfig` should be made named around
// `SingleRowPredictor`, because it is specific to single row prediction, and doesn't actually hold only config.
int LGBM_FastConfigFree(FastConfigHandle fastConfig) {
API_BEGIN();
delete reinterpret_cast<SingleRowPredictor*>(fastConfig);
Expand Down

0 comments on commit 993f8f5

Please sign in to comment.