Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Invoke and InvokeIf overloads to FluentExtensions #53

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Add Invoke and InvokeIf overloads to FluentExtensions #53

merged 2 commits into from
Jun 25, 2023

Conversation

ric15ni
Copy link
Contributor

@ric15ni ric15ni commented Jun 25, 2023

Proposed changes

See related issues.

Checklist of related issues / discussions

Types of changes

This pull request introduces the following types of changes:

  • Bug fix
  • New feature
  • Test addition / update (no changes to non-test code)
  • Refactor (no changes in public API syntax or semantics)
  • Performance improvement (no changes in public API syntax or semantics)
  • Documentation (docs directory) update
  • Dependency addition / update
  • Changes to the build scripts
  • Changes to CI (workflows, bot / app configurations)
  • Changes to repository files (.gitattributes, .gitignore)
  • Other

Breaking changes

This pull request introduces breaking changes:

  • Yes
  • No

Checklist

  • For all types of changes:
  • For code changes only:
    • The project builds on my machine, via the provided build script, with zero warnings
    • I have added tests that prove my feature works / my fix is effective
    • I have added / modified XML documentation according to changes in code
    • I have checked that all the links I added or modified in XML documentation point to their intended destination
  • For documentation changes (docs directory) only:
    • I have built and tested documentation locally
    • I have checked that all the links I added or modified point to their intended destination

@github-actions github-actions bot added area:code [issue/PR] affects project code (excluding tests). area:docs [issue/PR] affects documentation (excluding XML documentation that is part of source code). labels Jun 25, 2023
rdeago
rdeago approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@rdeago rdeago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rdeago rdeago merged commit 04128b4 into Tenacom:main Jun 25, 2023
5 checks passed
@ric15ni ric15ni deleted the more-fluency branch June 25, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdeago rdeago rdeago approved these changes

Assignees
No one assigned
Labels
area:code [issue/PR] affects project code (excluding tests). area:docs [issue/PR] affects documentation (excluding XML documentation that is part of source code).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an InvokeIf method to FluentExtensions Add FluentExtensions.Invoke overloads with additional parameters
2 participants
@ric15ni @rdeago