Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Louis.Logging #80

Merged
merged 6 commits into from
Sep 21, 2023
Merged

Remove Louis.Logging #80

merged 6 commits into from
Sep 21, 2023

Conversation

ric15ni
Copy link
Contributor

@ric15ni ric15ni commented Sep 21, 2023

Proposed changes

Remove the Louis.Logging library, for the reasons laid out in #79.

Checklist of related issues / discussions

Fixes #79.

Types of changes

This pull request introduces the following types of changes:

  • Bug fix
  • New feature
  • Test addition / update (no changes to non-test code)
  • Refactor (no changes in public API syntax or semantics)
  • Performance improvement (no changes in public API syntax or semantics)
  • Documentation (docs directory) update
  • Dependency addition / update
  • Changes to the build scripts
  • Changes to CI (workflows, bot / app configurations)
  • Changes to repository files (.gitattributes, .gitignore)
  • Other

This pull request removes the Louis.Logging library and the related test project.

Breaking changes

This pull request introduces breaking changes:

  • Yes
  • No

Checklist

  • For all types of changes:
  • For code changes only:
    • The project builds on my machine, via the provided build script, with zero warnings
    • I have added tests that prove my feature works / my fix is effective
    • I have added / modified XML documentation according to changes in code
    • I have checked that all the links I added or modified in XML documentation point to their intended destination
  • For documentation changes (docs directory) only:
    • I have built and tested documentation locally
    • I have checked that all the links I added or modified point to their intended destination

@github-actions github-actions bot added area:code [issue/PR] affects project code (excluding tests). area:docs [issue/PR] affects documentation (excluding XML documentation that is part of source code). labels Sep 21, 2023
@rdeago rdeago merged commit b739dff into Tenacom:main Sep 21, 2023
5 checks passed
@ric15ni ric15ni deleted the remove-louis.logging branch September 21, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:code [issue/PR] affects project code (excluding tests). area:docs [issue/PR] affects documentation (excluding XML documentation that is part of source code).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Louis.Logging library
2 participants