fix(web-renderer): fix codeReview issue

Tencent · Sep 22, 2023 · 696f203 · 696f203
1 parent 9237ee0
commit 696f203
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/driver/js/packages/hippy-web-renderer/src/component/list-view.ts b/driver/js/packages/hippy-web-renderer/src/component/list-view.ts
@@ -70,7 +70,7 @@ export class ListView extends HippyWebView<HTMLDivElement> {
   }
 
   public defaultStyle() {
-    return  { display: 'flex', flex: 1, flexDirection: 'column', flexShrink: 0, boxSizing: 'border-box', overflow: 'scroll' };
+    return  { display: 'flex', flexDirection: 'column', flexShrink: 0, boxSizing: 'border-box', overflow: 'scroll' };
   }
 
   public get overScrollEnabled() {

diff --git a/driver/js/packages/hippy-web-renderer/src/env/dynamic-load.ts b/driver/js/packages/hippy-web-renderer/src/env/dynamic-load.ts
@@ -18,17 +18,17 @@
  * limitations under the License.
  */
 
-export const dynamicLoad = (path: string, cb) => {
-  const s = document.createElement('script');
-  s.async = true;
-  s.setAttribute('src', path);
-  if (cb) {
-    s.onload = () => {
-      cb();
+export const dynamicLoad = (path: string, callback: Function): void => {
+  const script = document.createElement('script');
+  script.async = true;
+  script.setAttribute('src', path);
+  if (typeof callback === 'function') {
+    script.onload = () => {
+      callback();
     };
-    s.onerror = () => {
-      cb('load script error');
+    script.onerror = () => {
+      callback(`load script "${path}" error`);
     };
   }
-  document.head.appendChild(s);
+  document.head.appendChild(script);
 };