feat(android): make TextInput default color same as iOS

Tencent · Nov 24, 2023 · dd9eebd · dd9eebd
1 parent bb9b7db
commit dd9eebd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/...er/native/android/src/main/java/com/tencent/mtt/hippy/views/textinput/HippyTextInput.java b/...er/native/android/src/main/java/com/tencent/mtt/hippy/views/textinput/HippyTextInput.java
@@ -104,6 +104,8 @@ public HippyTextInput(Context context) {
                 ViewGroup.LayoutParams.MATCH_PARENT));
         setPadding(0, 0, 0, 0);
         setGravityVertical(Gravity.CENTER_VERTICAL);
+        setHintTextColor(HippyTextInputController.DEFAULT_PLACEHOLDER_TEXT_COLOR);
+        setTextColor(HippyTextInputController.DEFAULT_TEXT_COLOR);
     }
 
     @Override

diff --git a/...android/src/main/java/com/tencent/mtt/hippy/views/textinput/HippyTextInputController.java b/...android/src/main/java/com/tencent/mtt/hippy/views/textinput/HippyTextInputController.java
@@ -64,6 +64,8 @@
 public class HippyTextInputController extends HippyViewController<HippyTextInput> {
 
     public static final String CLASS_NAME = "TextInput";
+    static final int DEFAULT_TEXT_COLOR = Color.BLACK;
+    static final int DEFAULT_PLACEHOLDER_TEXT_COLOR = Color.GRAY;
     private static final String TAG = "HippyTextInputControlle";
     private static final int INPUT_TYPE_KEYBOARD_NUMBERED =
             InputType.TYPE_CLASS_NUMBER | InputType.TYPE_NUMBER_FLAG_DECIMAL
@@ -324,7 +326,8 @@ public void placeHolder(HippyTextInput view, String placeholder) {
         view.setHint(placeholder);
     }
 
-    @HippyControllerProps(name = "placeholderTextColor", defaultType = HippyControllerProps.NUMBER, defaultNumber = Color.GRAY)
+    @HippyControllerProps(name = "placeholderTextColor", defaultType = HippyControllerProps.NUMBER, defaultNumber =
+            DEFAULT_PLACEHOLDER_TEXT_COLOR)
     public void setTextHitColor(HippyTextInput input, int color) {
         input.setHintTextColor(color);
     }
@@ -366,12 +369,11 @@ public void setOnContentSizeChange(HippyTextInput hippyTextInput, boolean conten
     }
 
     @HippyControllerProps(name = NodeProps.COLOR, defaultType = HippyControllerProps.NUMBER, defaultNumber =
-            Color.BLACK)
+            DEFAULT_TEXT_COLOR)
     public void setColor(HippyTextInput hippyTextInput, int change) {
         hippyTextInput.setTextColor(change);
     }
 
-
     @HippyControllerProps(name = NodeProps.TEXT_ALIGN, defaultType = HippyControllerProps.STRING)
     public void setTextAlign(HippyTextInput view, String textAlign) {
         if (textAlign == null || "auto".equals(textAlign)) {