refactor(ios): Revert rename and Sdk frame refactor and Fix some bug #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the original rename pr is Tencent#2165
|
Hi, @wwwcg. Thanks for your PR! 👏 🏷️ You can leave a comment in this PR with |
wwwcg
force-pushed
the
frame_refactor
branch
2 times, most recently
from
d9f5695 to
5a25dc4
Compare
|
|
HippyRootView and sdk start related change
sync from hippy2
|
🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.
|
remove all deprecated Header Search Path settings in user_target_xcconfig
github-actions
bot
added
framework: android
driver: js
dom: tree
module: footstone
labels
wwwcg
dismissed stale reviews from ruifanyuan, etkmao, zealotchen0, and ilikethese
The merge-base changed after approval.
github-actions
bot
removed
framework: android
driver: js
dom: tree
module: footstone
labels
etkmao
approved these changes
Oct 18, 2023
ilikethese
approved these changes
Oct 18, 2023
zealotchen0
approved these changes
Oct 18, 2023
ruifanyuan
approved these changes
Oct 19, 2023
|
🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.
|
hippy-actions
bot
added
action(rebase-merge): failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: