Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(driver): fix multi thead conflict when destroy engine #3549

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(driver): fix multi thead conflict when destroy engine #3549

merged 1 commit into from
Oct 17, 2023

Conversation

ilikethese
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@ilikethese ilikethese requested a review from etkmao as a code owner October 17, 2023 05:15
@github-actions github-actions bot added framework: android driver: js size: s Denotes a PR that changes 10-99 lines labels Oct 17, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 17, 2023

Hi, @ilikethese. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Oct 17, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Oct 17, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) October 17, 2023 06:54
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Oct 17, 2023
@hippy-actions hippy-actions bot merged commit 0658dc3 into Tencent:main Oct 17, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etkmao etkmao etkmao approved these changes

Assignees
No one assigned
Labels
driver: js framework: android size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilikethese @etkmao