Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): fontWeight support number value #3570

Merged
merged 3 commits into from
Nov 23, 2023
Merged

feat(android): fontWeight support number value #3570

merged 3 commits into from
Nov 23, 2023

Conversation

iPel
Copy link
Collaborator

@iPel iPel commented Oct 27, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added renderer: native doc: pages size: m Denotes a PR that changes 100-499 lines labels Oct 27, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 27, 2023

Hi, @iPel. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@iPel iPel added the consistency consistency between android and ios label Oct 31, 2023
siguangli
siguangli previously approved these changes Nov 16, 2023
View reviewed changes
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 23, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@siguangli siguangli added the action(squash-merge) Squash and merge action label Nov 23, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) November 23, 2023 11:49
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Nov 23, 2023
@hippy-actions hippy-actions bot merged commit bb9b7db into Tencent:main Nov 23, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

@siguangli siguangli siguangli approved these changes

Assignees
No one assigned
Labels
consistency consistency between android and ios doc: pages renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iPel @siguangli @zealotchen0 @open-hippy