Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(renderer): support scrollEventThrottle on Android and iOS #3581

Closed
wants to merge 13 commits into from
Closed

feat(renderer): support scrollEventThrottle on Android and iOS #3581

wants to merge 13 commits into from

Conversation

arvinwli
Copy link

@arvinwli arvinwli commented Oct 31, 2023 •
edited
Loading

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@tencent-adm
Copy link
Member

tencent-adm commented Oct 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size: s Denotes a PR that changes 10-99 lines label Oct 31, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 31, 2023

Hi, @arvinwli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Oct 31, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@arvinwli arvinwli changed the title 实现 viewpager 滑动防抖能力 feat(ios/android): support scrollEventThrottle Oct 31, 2023
@arvinwli arvinwli force-pushed the feature/arvinwli_viewpager_throttle branch from 2782302 to 6ddf3ea Compare October 31, 2023 02:48
@arvinwli arvinwli closed this Oct 31, 2023
@arvinwli arvinwli reopened this Oct 31, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 31, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@arvinwli arvinwli force-pushed the feature/arvinwli_viewpager_throttle branch from a8e04fb to 188221e Compare October 31, 2023 03:02
@arvinwli arvinwli closed this Oct 31, 2023
@arvinwli arvinwli reopened this Oct 31, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 31, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@arvinwli arvinwli force-pushed the feature/arvinwli_viewpager_throttle branch from 188221e to 363f7e7 Compare October 31, 2023 03:27
@arvinwli arvinwli closed this Oct 31, 2023
@arvinwli arvinwli reopened this Oct 31, 2023
@hippy-service
Copy link

hippy-service bot commented Oct 31, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@arvinwli arvinwli changed the title feat(ios/android): support scrollEventThrottle feat: support scrollEventThrottle on Android and iOS Oct 31, 2023
@arvinwli arvinwli changed the title feat: support scrollEventThrottle on Android and iOS feat(renderer): support scrollEventThrottle on Android and iOS Oct 31, 2023
@arvinwli arvinwli force-pushed the feature/arvinwli_viewpager_throttle branch from 363f7e7 to 5862cf5 Compare October 31, 2023 06:16
@arvinwli arvinwli closed this Oct 31, 2023
@arvinwli arvinwli reopened this Oct 31, 2023
iPel
iPel reviewed Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档和vue demo需要补充下
docs/api/hippy-react/components.md
docs/api/hippy-vue/components.md
driver/js/examples/hippy-vue-demo/src/components/native-demos/demo-swiper.vue
driver/js/examples/hippy-vue-next-demo/src/components/native-demo/demo-swiper.vue

...android/src/main/java/com/tencent/mtt/hippy/views/viewpager/ViewPagerPageChangeListener.java Outdated Show resolved Hide resolved
@arvinwli arvinwli requested a review from iPel November 1, 2023 02:02
iPel
iPel previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 1, 2023

After a quick scan, I have approved workflow to run.

@arvinwli arvinwli force-pushed the feature/arvinwli_viewpager_throttle branch from 6efe4a4 to 44b915c Compare November 1, 2023 07:38
@arvinwli arvinwli requested a review from zealotchen0 November 1, 2023 08:06
zealotchen0
zealotchen0 previously approved these changes Nov 1, 2023
View reviewed changes
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 1, 2023

After a quick scan, I have approved workflow to run.

@arvinwli arvinwli force-pushed the feature/arvinwli_viewpager_throttle branch from 900ba88 to 12880a1 Compare November 2, 2023 02:45
siguangli
siguangli previously approved these changes Nov 2, 2023
View reviewed changes
@arvinwli arvinwli dismissed stale reviews from siguangli and zealotchen0 via 9d65d5e November 7, 2023 08:53
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 9, 2023

After a quick scan, I have approved workflow to run.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 20, 2024

Pay attention 🛎️ !!
There has been no activity on this PR for 2 months, so I will label it stalled.
It will be automatically closed in 30 days if no more activity. Feel free to leave a comment if you have any questions.

@hippy-service hippy-service bot added the stale: 60d No interaction in the last 60 days label Jan 20, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Mar 21, 2024

Sorry, closing this PR because it has stalled for over 4 months.
Feel free to reopen if this PR is still relevant, or to ping the collaborator if you have any questions.

@hippy-service hippy-service bot added the stale: closed Closed due to stale label Mar 21, 2024
@hippy-service hippy-service bot closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPel iPel iPel approved these changes

@zealotchen0 zealotchen0 zealotchen0 left review comments

@siguangli siguangli siguangli left review comments

@wwwcg wwwcg Awaiting requested review from wwwcg wwwcg is a code owner

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

Assignees
No one assigned
Labels
doc: pages driver: js renderer: native size: m Denotes a PR that changes 100-499 lines stale: closed Closed due to stale stale: 60d No interaction in the last 60 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arvinwli @tencent-adm @iPel @siguangli @zealotchen0