Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): deprecate underlineColorAndroid prop #3634

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

iPel
Copy link
Collaborator

@iPel iPel commented Nov 24, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added renderer: native doc: pages size: s Denotes a PR that changes 10-99 lines labels Nov 24, 2023
Copy link

hippy-service bot commented Nov 24, 2023

Hi, @iPel. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@iPel iPel force-pushed the underline_color_android branch from c69a426 to ee38f43 Compare November 24, 2023 06:46
@iPel iPel added the consistency consistency between android and ios label Nov 28, 2023
Copy link

hippy-service bot commented Nov 30, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 30, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) November 30, 2023 03:18
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 30, 2023
@hippy-actions hippy-actions bot merged commit acce0e6 into Tencent:main Nov 30, 2023
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency consistency between android and ios doc: pages renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants