Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add modal features #3680

Merged
merged 19 commits into from
Feb 1, 2024
Merged

Conversation

Xuanquan-Zhuang
Copy link
Contributor

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

Copy link

hippy-service bot commented Dec 25, 2023

Hi, @Xuanquan-Zhuang. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link

hippy-service bot commented Dec 25, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

zealotchen0
zealotchen0 previously approved these changes Jan 12, 2024
siguangli
siguangli previously approved these changes Jan 12, 2024
@Xuanquan-Zhuang Xuanquan-Zhuang dismissed stale reviews from siguangli and zealotchen0 via ff3b75a January 16, 2024 06:44
Copy link

hippy-service bot commented Jan 16, 2024

After a quick scan, I have approved workflow to run.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 16, 2024
Copy link

hippy-service bot commented Jan 16, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-actions hippy-actions bot enabled auto-merge (rebase) January 16, 2024 07:00
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 16, 2024
@siguangli siguangli added the action(squash-merge) Squash and merge action label Jan 16, 2024
@hippy-actions hippy-actions bot disabled auto-merge January 16, 2024 09:12
@hippy-actions hippy-actions bot enabled auto-merge (squash) January 16, 2024 09:12
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jan 16, 2024
Copy link

hippy-service bot commented Jan 31, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 31, 2024
@hippy-actions hippy-actions bot disabled auto-merge January 31, 2024 04:06
@hippy-actions hippy-actions bot enabled auto-merge (rebase) January 31, 2024 04:06
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 31, 2024
@zealotchen0 zealotchen0 disabled auto-merge February 1, 2024 12:04
@zealotchen0 zealotchen0 enabled auto-merge (squash) February 1, 2024 12:05
@zealotchen0 zealotchen0 disabled auto-merge February 1, 2024 12:05
@zealotchen0 zealotchen0 merged commit 98df553 into Tencent:main Feb 1, 2024
34 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc: pages driver: js renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants