Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): remove unused initialization param of HippyRootView & doc update #3698

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix(ios): remove unused initialization param of HippyRootView & doc update #3698

merged 1 commit into from
Jan 26, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Dec 28, 2023

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework: ios doc: example doc: pages size: m Denotes a PR that changes 100-499 lines labels Dec 28, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Dec 28, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg wwwcg merged commit 4cfdb8f into Tencent:master Jan 26, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

Assignees
No one assigned
Labels
doc: example doc: pages framework: ios size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwcg @zealotchen0