Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): animation nullptr crash #3876

Merged
merged 1 commit into from
May 29, 2024
Merged

fix(ios): animation nullptr crash #3876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dom/src/dom/animation/animation_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ void AnimationManager::EmplaceNodeProp(const std::shared_ptr<DomNode>& node, con
animation_nodes_map_.insert({animation_id, nodeIds});
}
auto animation = GetAnimation(animation_id);
node->EmplaceStyleMap(prop, HippyValue(animation->GetStartValue()));
if (animation) {
node->EmplaceStyleMap(prop, HippyValue(animation->GetStartValue()));
}
}

void AnimationManager::ParseAnimation(const std::shared_ptr<DomNode>& node) {
Expand Down
Loading