Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/anim state crash #3891

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Bugfix/anim state crash #3891

merged 3 commits into from
Jun 11, 2024

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Jun 11, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested a review from ilikethese as a code owner June 11, 2024 08:14
@etkmao etkmao requested a review from siguangli June 11, 2024 08:14
@github-actions github-actions bot added framework: android dom: animation size: xs Denotes a PR that changes 0-9 lines labels Jun 11, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jun 11, 2024

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@siguangli siguangli merged commit a6d3da3 into Tencent:main Jun 11, 2024
20 of 23 checks passed
siguangli pushed a commit to siguangli/Hippy that referenced this pull request Jun 11, 2024
@etkmao @siguangli2018
Bugfix/anim state crash (Tencent#3891)
dc7618d 
* fix(perf): animation state not crash on release version

* fix(core): crash protect when onInstanceDestroy is invoked 2 timers

* fix(core): animation state not crash on release version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese

Assignees
No one assigned
Labels
dom: animation framework: android size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etkmao @siguangli