Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): add paragraph styles support for TextInput #3910

Merged
merged 1 commit into from
Jun 17, 2024
Merged

feat(ios): add paragraph styles support for TextInput #3910

merged 1 commit into from
Jun 17, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Jun 17, 2024

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@tencent-adm
Copy link
Member

tencent-adm commented Jun 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size: m Denotes a PR that changes 100-499 lines label Jun 17, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jun 17, 2024

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg wwwcg force-pushed the feat/lineHeight_textinput branch 2 times, most recently from 33184a2 to 30e5a9e Compare June 17, 2024 10:30
@wwwcg
feat(ios): add paragraph styles support for TextInput
e416db1 
TextInput Current support:
1.lineHeight
2.lineSpacing
3.lineHeightMultiple
@wwwcg wwwcg force-pushed the feat/lineHeight_textinput branch from 30e5a9e to e416db1 Compare June 17, 2024 10:36
@wwwcg wwwcg merged commit 041db25 into Tencent:master Jun 17, 2024
17 of 23 checks passed
@wwwcg wwwcg deleted the feat/lineHeight_textinput branch June 17, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 Awaiting requested review from zealotchen0 zealotchen0 is a code owner

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

Assignees
No one assigned
Labels
doc: example framework: ios size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwcg @tencent-adm