Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios): remove unused code in TextView #3912

Merged
merged 1 commit into from
Jun 17, 2024
Merged

chore(ios): remove unused code in TextView #3912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ios/sdk/component/textinput/HippyTextField.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
@interface HippyTextField : HippyBaseTextInput <UITextFieldDelegate>
@property (nonatomic, copy) HippyDirectEventBlock onKeyPress;
@property (nonatomic, assign) BOOL autoCorrect;
//@property (nonatomic, assign) UIEdgeInsets contentInset;
@property (nonatomic, strong) UIColor *placeholderTextColor;
@property (nonatomic, strong) NSString *placeholder;
@property (nonatomic, strong) NSNumber *maxLength;
Expand All @@ -66,7 +65,6 @@
@property (nonatomic, copy) HippyDirectEventBlock onKeyboardHeightChanged;

@property (nonatomic, copy) NSString *value;
@property (nonatomic, strong) NSNumber *fontSize;
@property (nonatomic, strong) NSString *defaultValue;
@property (nonatomic, copy) NSString *text;
@property (nonatomic, strong) UIColor *textColor;
Expand Down
7 changes: 0 additions & 7 deletions ios/sdk/component/textinput/HippyTextField.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,13 +363,6 @@ - (void)setText:(NSString *)text {
_text = text;
}

- (void)setFontSize:(NSNumber *)fontSize {
_fontSize = fontSize;
if ([fontSize floatValue] > 0) {
[_textView setFont:[UIFont systemFontOfSize:[fontSize floatValue]]];
}
}

- (void)setValue:(NSString *)value {
[_textView setText:value];
}
Expand Down
2 changes: 0 additions & 2 deletions ios/sdk/component/textinput/HippyTextView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
@property (nonatomic, assign) BOOL blurOnSubmit;
@property (nonatomic, assign) BOOL clearTextOnFocus;
@property (nonatomic, assign) BOOL selectTextOnFocus;
//@property (nonatomic, assign) UIEdgeInsets contentInset;
@property (nonatomic, assign) BOOL automaticallyAdjustContentInsets;
@property (nonatomic, copy) NSString *text;
@property (nonatomic, strong) UIColor *placeholderTextColor;
Expand All @@ -64,7 +63,6 @@
- (void)performTextUpdate;

@property (nonatomic, copy) NSString *value;
@property (nonatomic, strong) NSNumber *fontSize;
@property (nonatomic, strong) NSString *defaultValue;
@property (nonatomic, strong) UIColor *textColor;

Expand Down
8 changes: 0 additions & 8 deletions ios/sdk/component/textinput/HippyTextView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,14 +777,6 @@ - (void)setValue:(NSString *)value {
[self setText:value];
}

- (void)setFontSize:(NSNumber *)fontSize {
_fontSize = fontSize;

if ([fontSize floatValue] > 0) {
[self setFont:[UIFont systemFontOfSize:[fontSize floatValue]]];
}
}

- (void)setDefaultValue:(NSString *)defaultValue {
if (defaultValue) {
[self setText:defaultValue];
Expand Down
Loading