Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): font weight compatible with version 2.x #3948

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@github-actions github-actions bot added driver: js renderer: native doc: pages size: m Denotes a PR that changes 100-499 lines labels Jul 9, 2024
@tencent-adm
Copy link
Member

tencent-adm commented Jul 9, 2024

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ siguangli
❌ siguangli2018
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

hippy-service bot commented Jul 9, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

*/
@Deprecated
public static void apply(Paint paint, int style, int weight, String family,
public static void apply(Paint paint, int style, String weight, String family,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个方法如果有外部调用,就保持参数不要变,否则可以直接删掉

Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siguangli siguangli enabled auto-merge (squash) July 10, 2024 06:07
@siguangli siguangli disabled auto-merge July 10, 2024 06:12
@siguangli siguangli merged commit d967cba into Tencent:main Jul 10, 2024
21 of 27 checks passed
@siguangli siguangli deleted the fix/fontWeight branch July 10, 2024 06:12
siguangli added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc: pages driver: js renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants