Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): turbo module type convert nullptr crash #3958

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(ios): turbo module type convert nullptr crash #3958

merged 1 commit into from
Jul 19, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Jul 19, 2024

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework: ios driver: js size: xs Denotes a PR that changes 0-9 lines labels Jul 19, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jul 19, 2024

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg wwwcg merged commit fb55d09 into Tencent:master Jul 19, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

@ilikethese ilikethese Awaiting requested review from ilikethese ilikethese is a code owner

@etkmao etkmao Awaiting requested review from etkmao etkmao is a code owner

Assignees
No one assigned
Labels
driver: js framework: ios size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wwwcg