Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsc): fix jscctx finalize crash #4154

Merged
merged 1 commit into from
Dec 25, 2024
Merged

fix(jsc): fix jscctx finalize crash #4154

merged 1 commit into from
Dec 25, 2024

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Dec 24, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@etkmao etkmao requested a review from wwwcg December 24, 2024 13:57
@etkmao etkmao requested a review from ilikethese as a code owner December 24, 2024 13:57
@github-actions github-actions bot added driver: js size: xs Denotes a PR that changes 0-9 lines labels Dec 24, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Dec 24, 2024

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg wwwcg merged commit 4ba13cc into Tencent:main Dec 25, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwwcg wwwcg wwwcg approved these changes

@ilikethese ilikethese Awaiting requested review from ilikethese ilikethese is a code owner

Assignees
No one assigned
Labels
driver: js size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etkmao @wwwcg