fix test case bad version

Tencent · Dec 6, 2024 · cd18289 · cd18289
1 parent 3f8c1d5
commit cd18289
Show file tree

Hide file tree

Showing 3 changed files with 613 additions and 606 deletions.
diff --git a/src/rendering/filters/layerstyle/SolidStrokeFilter.cpp b/src/rendering/filters/layerstyle/SolidStrokeFilter.cpp
@@ -170,6 +170,9 @@ std::shared_ptr<tgfx::RuntimeEffect> SolidStrokeFilter::onCreateEffect(
   newOption.spreadSizeY *= filterScale.y;
   newOption.offsetX *= filterScale.x;
   newOption.offsetY *= filterScale.y;
+  if (!newOption.valid()) {
+    return nullptr;
+  }
   if (styleMode == SolidStrokeMode::Normal) {
     return SolidStrokeNormalEffect::Make(newOption, originalImage);
   } else {

diff --git a/src/rendering/filters/layerstyle/SolidStrokeFilter.h b/src/rendering/filters/layerstyle/SolidStrokeFilter.h
@@ -32,6 +32,10 @@ struct SolidStrokeOption {
   float spreadSizeY = 0.0f;
   float offsetX = 0.0f;
   float offsetY = 0.0f;
+
+  bool valid() {
+    return opacity != 0 && (spreadSizeX != 0 || spreadSizeY !=0 || offsetX != 0 || offsetY != 0);
+  }
 };
 
 class SolidStrokeUniforms : public Uniforms {