Update tgfx to the lastest version. #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hparty
requested review from
kevingpqi123,
domchen and
shlzxjp
as code owners
domchen
reviewed
Nov 11, 2024
| @@ -852,8 +844,10 @@ void ApplyStrokeToPath(tgfx::Path* path, const StrokePaint& stroke) { | |||
| } | |||
| } | |||
| for (const auto& effect : effects) { | |||
| effect->applyTo(path); | |||
| effect->filterPath(path); | |||
There was a problem hiding this comment.
这里是不是不需要数组了，只有一个dasheffect
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
+ Coverage 77.35% 77.37% +0.02%
==========================================
Files 420 420
Lines 22460 22450 -10
Branches 6361 6355 -6
==========================================
- Hits 17373 17371 -2
- Misses 3814 3816 +2
+ Partials 1273 1263 -10 ☔ View full report in Codecov by Sentry. |
domchen
reviewed
Nov 12, 2024
Comment on lines
834
to
838
| dashEffect->filterPath(path); | ||
| } | ||
| } | ||
| auto strokeData = stroke.getStroke(); | ||
| auto strokeEffect = tgfx::PathEffect::MakeStroke(&strokeData); | ||
| if (strokeEffect) { | ||
| effects.emplace_back(std::move(strokeEffect)); | ||
| } | ||
| if (effects.empty()) { | ||
| return; | ||
| } | ||
| strokeData.applyToPath(path); |
There was a problem hiding this comment.
这些需要在Transform之后才能应用，顺序错了。
domchen
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.