Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayerStyle supports deferred rendering. #2607

Merged
merged 16 commits into from
Dec 11, 2024
Merged

LayerStyle supports deferred rendering. #2607

merged 16 commits into from
Dec 11, 2024

Conversation

Hparty
Copy link
Collaborator

@Hparty Hparty commented Dec 5, 2024

No description provided.

@Hparty Hparty closed this Dec 9, 2024
…pdate_tgfx

# Conflicts:
#	DEPS   resolved by a09147a version
#	test/baseline/version.json
@Hparty Hparty reopened this Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 82.43560% with 75 lines in your changes missing coverage. Please review.

Project coverage is 77.28%. Comparing base (504de7f) to head (6be2d0d).

Files with missing lines Patch % Lines
src/rendering/filters/RuntimeFilter.cpp 77.39% 14 Missing and 12 partials ⚠️
...c/rendering/filters/layerstyle/SolidStrokeFilter.h 50.00% 2 Missing and 17 partials ⚠️
src/rendering/filters/LayerStylesFilter.cpp 75.00% 3 Missing and 3 partials ⚠️
...c/rendering/filters/layerstyle/OuterGlowFilter.cpp 82.85% 3 Missing and 3 partials ⚠️
.../rendering/filters/layerstyle/DropShadowFilter.cpp 90.24% 2 Missing and 2 partials ⚠️
src/rendering/filters/layerstyle/StrokeFilter.cpp 89.18% 2 Missing and 2 partials ⚠️
...ndering/filters/layerstyle/AlphaEdgeDetectFilter.h 66.66% 0 Missing and 3 partials ⚠️
.../rendering/filters/layerstyle/LayerStyleFilter.cpp 80.00% 2 Missing and 1 partial ⚠️
...rendering/filters/layerstyle/SolidStrokeFilter.cpp 96.29% 1 Missing and 1 partial ⚠️
src/rendering/filters/RuntimeFilter.h 92.85% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
- Coverage   77.36%   77.28%   -0.09%     
==========================================
  Files         420      425       +5     
  Lines       22450    22464      +14     
  Branches     6355     6355              
==========================================
- Hits        17369    17361       -8     
+ Misses       3816     3809       -7     
- Partials     1265     1294      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hparty Hparty closed this Dec 10, 2024
@Hparty Hparty reopened this Dec 10, 2024
@Hparty Hparty closed this Dec 10, 2024
@Hparty Hparty reopened this Dec 10, 2024
@@ -17,6 +17,8 @@
/////////////////////////////////////////////////////////////////////////////////////////////////

#include "LayerStylesFilter.h"
#include <tgfx/core/Surface.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用尖括号

}
context->flush();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里删掉

int textureCoordHandle = -1;
};

class EffectProgram : public tgfx::RuntimeProgram {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RuntimeFilter


namespace pag {

class AlphaEdgeDetectEffectUniforms : public Uniforms {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

都改名为Filter,避免和PAG的Effect概念冲突。

@domchen domchen merged commit 238ff8e into main Dec 11, 2024
8 checks passed
@domchen domchen deleted the bugfix/update_tgfx branch December 11, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants