Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable -ffast-math on x86 arch (#5051) #5052

Closed

Conversation

zchrissirhcz
Copy link
Contributor

For the issue #5051

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #5052 (7377f1b) into master (1d7720e) will decrease coverage by 5.30%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5052       +/-   ##
===========================================
- Coverage   94.73%   89.44%    -5.30%     
===========================================
  Files         767      254      -513     
  Lines      230159    68351   -161808     
===========================================
- Hits       218048    61134   -156914     
+ Misses      12111     7217     -4894     

see 678 files with indirect coverage changes

@zchrissirhcz zchrissirhcz marked this pull request as draft September 25, 2023 03:21
@zchrissirhcz zchrissirhcz force-pushed the disable-fast-math-on-x86 branch from 3361266 to 7377f1b Compare September 25, 2023 03:33
@zchrissirhcz zchrissirhcz marked this pull request as ready for review September 25, 2023 03:36
@nihui
Copy link
Member

nihui commented Oct 10, 2023

You should use the same version of the compiler to compile and link

Disabling fast-math may result in performance loss

@zchrissirhcz zchrissirhcz deleted the disable-fast-math-on-x86 branch November 27, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants