Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): 修改键盘事件绑定对象 #3728

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

sinbadmaster
Copy link
Contributor

closed #3636

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#3636

💡 需求背景和解决方案

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Dec 11, 2023

完成

@uyarn
Copy link
Collaborator

uyarn commented Jan 2, 2024

处理下冲突

@@ -246,12 +249,12 @@ export default defineComponent({
document.head.appendChild(styleEl.value);
}

window.addEventListener('keydown', handleEscKeydown);
// window.addEventListener('keydown', handleEscKeydown);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种不需要的就删掉吧 不用注释着

@uyarn uyarn self-requested a review January 2, 2024 12:08
@ls-v
Copy link

ls-v commented Oct 28, 2024

这个问题还没修复吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants