pref:完善研发商店组件配置文件参数校验 #11269 #11287
Open
pref:完善研发商店组件配置文件参数校验 #11269 #11287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kzhou991
requested review from
irwinsun,
mingshewhe,
stubenhuang,
carlyin0801,
royalhuang,
randychen2046 and
tangruotian
as code owners
…o issue_11269 # Conflicts: # support-files/i18n/store/message_en_US.properties
carlyin0801
reviewed
Dec 19, 2024
| throw ErrorCodeException( | ||
| errorCode = StoreMessageCode.USER_ATOM_OUTPUT_NUM_IS_TOO_MANY, | ||
| params = arrayOf(maxOutputNum.toString()) | ||
| errorCode = StoreMessageCode.USER_ATOM_INPUT_NUM_IS_TOO_MANY, |
There was a problem hiding this comment.
错误码怎么一刀切了，原来输出变量个数超了也用输出变量的错误码
| @@ -109,6 +109,8 @@ | |||
| 2120935=When the queryProjectComponentFlag, installed, or updateFlag parameters are not empty, the projectCode parameter must be non-empty | |||
| 2120936=store: Unreleased versions are not allowed to be removed from the shelves | |||
| 2120937=store: Code library deletion failed, failure reason: {0} | |||
|
|
|||
| 2120043=store: In the plugin configuration file [task.json], the field {0} contains the subfield {1}, which currently only supports {2} | |||
| ) | ||
| } | ||
| return GetAtomConfigResult("0", arrayOf(""), taskDataMap, atomEnvRequests) | ||
|
|
||
| dataMap.values |
There was a problem hiding this comment.
这段代码看起来只是校验支持的输出类型吧，其他情况根本无需执行吧，建议单独抽出来
| private fun <T : Any> validateTaskJsonField( | ||
| inputGroupMap: Map<String, Any>, | ||
| fieldName: String, | ||
| expectedType: KClass<T> |
There was a problem hiding this comment.
这个方法参数你加一个是否必填字段看起来更清晰，必填才需要校验是否非空
carlyin0801
reviewed
Dec 19, 2024
| ) | ||
| } | ||
| // pref:完善研发商店组件配置文件参数校验 #11269 | ||
| val supportedLanguages = setOf(JAVA, PYTHON, GOLANG, NODEJS) |
There was a problem hiding this comment.
这个和输出变量目前只支持三种类型的逻辑类似，统一封装一个公共方法，别各写各的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.