-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fast_transfer_file API 分发文件,如果源文件中的文件名包含空格,会报错 #812 #2041
Open
liuliaozhong
wants to merge
4
commits into
TencentBlueKing:master
Choose a base branch
from
liuliaozhong:master_issue812
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuliaozhong
force-pushed
the
master_issue812
branch
from
May 12, 2023 07:04
6b14ba3
to
80980e7
Compare
wangyu096
requested changes
May 12, 2023
|
||
// 路径中有合法的内置变量或全局变量通过校验 | ||
if (validateVariable(path)) { | ||
log.warn("The path {} contains legal variables", path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 不应该用warn,这里表示校验路径通过
- 这个日志建议删除
} | ||
if (!result) { | ||
// 路径不合法 | ||
log.error("The path {} is invalid and the verification fails", path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用warn级别即可,这个不是系统错误
wangyu096
approved these changes
May 15, 2023
liuliaozhong
force-pushed
the
master_issue812
branch
from
May 17, 2023 09:10
6ddd745
to
ba7323a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.