-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 定时任务兼容不合法主机 #3305 #3314
base: master
Are you sure you want to change the base?
feat: 定时任务兼容不合法主机 #3305 #3314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2个小问题需要处理下。
@@ -116,4 +116,11 @@ public static <E, K, V> Map<K, V> convertToMap(List<E> entityCollection, | |||
} | |||
return map; | |||
} | |||
|
|||
public static <T> ArrayList<T> mergeToArrayList(List<T> list1, List<T> list2) { | |||
ArrayList<T> mergeList = new ArrayList<>(list1.size() + list2.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议增加对null值的处理
} else if (!isSourceAgentInstalled) { | ||
return "Agent is not installed"; | ||
} else { | ||
// 源、目标正常,无法写入错误日志 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
无法->无需
处理 Code Review
需求:定时任务触发的作业,如果包含了不合法的主机,就忽略这部分主机,继续执行;同时任务报错