Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected the name of parameters #393

Closed
wants to merge 1 commit into from
Closed

Corrected the name of parameters #393

wants to merge 1 commit into from

Conversation

shtripat
Copy link
Member

Signed-off-by: Shubhendu [email protected]

@shtripat shtripat requested review from a team as code owners March 15, 2018 08:43
@shtripat
Copy link
Member Author

@shirshendu plz review

@shirshendu
Copy link

Please see discussion here and here. We need to be doing validation from master definitions, and not adding per-api validations. I'm already looking into that.

@r0h4n
Copy link
Contributor

r0h4n commented Mar 15, 2018

@shirshendu The validations wont be part of 3.4 downstream, we need to review/merge this PR as a short term solution

@shirshendu
Copy link

#396

@shirshendu shirshendu closed this Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0h4n r0h4n r0h4n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shtripat @shirshendu @r0h4n