Status screen rework #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 3, 2018 17:31
… for the effects
skaldarnar
approved these changes
Apr 18, 2020
|
|
||
|
|
||
| @RegisterSystem(RegisterMode.CLIENT) | ||
| public class PotionStatusUISystem extends BaseComponentSystem { | ||
|
|
||
| private static final String PERIODIC_ACTION_ID = "PotionStatusScreenUI"; | ||
| private static final String TARGET_SCREEN_NAME = "Core:InventoryScreen"; |
There was a problem hiding this comment.
Suggested change
| private static final String TARGET_SCREEN_NAME = "Core:InventoryScreen"; | |
| private static final String TARGET_SCREEN_NAME = "Inventory:InventoryScreen"; |
There was a problem hiding this comment.
weirdly, it doesn't work for me locally if I use Inventory:InventoryScreen ... what is this referring to? 🤔
|
|
||
| public PotionStatusWidget() { | ||
| effects.setFillVerticalSpace(false); | ||
| effects.addWidget(new UILabel("Potion Effects:")); |
There was a problem hiding this comment.
This will always show the label, even if no potions are active. This could be improved later on.
skaldarnar
requested changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the status screen to be less of a pile of code smells.
In particular it actually integrates it into the inventory and allows for a variable number of effects.
To Test
Simply drink some potions and open up the inventory, there should be a screen on the right
Outstanding
Make potion effects automatically load from the player.