Skip to content

Commit

Permalink
Merge pull request #3420 from TomJGooding/fix-console-fix-selective-e…
Browse files Browse the repository at this point in the history
…nabling-of-highlighting

fix(console): fix selective enabling of highlighting
  • Loading branch information
willmcgugan authored Aug 26, 2024
2 parents e1e6d74 + 1174c72 commit 7eaaa66
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Progress track thread is now a daemon thread https://github.com/Textualize/rich/pull/3402
- Fixed cached hash preservation upon clearing meta and links https://github.com/Textualize/rich/issues/2942
- Fixed overriding the `background_color` of `Syntax` not including padding https://github.com/Textualize/rich/issues/3295
- Fixed selective enabling of highlighting when disabled in the `Console` https://github.com/Textualize/rich/issues/3419

### Changed

Expand Down
6 changes: 5 additions & 1 deletion rich/console.py
Original file line number Diff line number Diff line change
Expand Up @@ -1535,7 +1535,11 @@ def check_text() -> None:
if isinstance(renderable, str):
append_text(
self.render_str(
renderable, emoji=emoji, markup=markup, highlighter=_highlighter
renderable,
emoji=emoji,
markup=markup,
highlight=highlight,
highlighter=_highlighter,
)
)
elif isinstance(renderable, Text):
Expand Down

0 comments on commit 7eaaa66

Please sign in to comment.