Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with custom classes (fixes #2875) #3006

Merged
merged 2 commits into from
Jul 29, 2023

Conversation

AryazE
Copy link
Contributor

@AryazE AryazE commented Jun 22, 2023

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

When repring classes that have overwritten __eq__ as parameters, the check with == Parameters.empty can be True.
Fixes #2875 with the suggested change. Also added the sample code as a test.

@willmcgugan willmcgugan merged commit 236e8e8 into Textualize:master Jul 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Class of default value may change behavior of repr auto generation
2 participants