Modernize code #3072
Closed
Modernize code #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basnijholt
approved these changes
Dec 22, 2023
|
Most of these changes are fairly arbitrary. Some may be worthwhile, but some its not clear what the benefit of the change is. Without knowing the issue they are fixing, its just not worth merging new code. I'd suggest separating the cosmetic changes, from larger changes, and submitting them separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
It's just a refactoring: use f-strings and integers, and simplify some parts of the code. No functionality modified.
Also
blackwanted to make plenty of changes to existing code, so I did not apply it now. Anyway, please be pedantic! :-)