Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3104 #3105

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

AaronBeaudoin
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

See #3104

Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

I've fixed the failing tests, updated the changelog, and added you to the contributors list.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aabfd16) 98.30% compared to head (1ab892e) 98.28%.
Report is 32 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3105      +/-   ##
==========================================
- Coverage   98.30%   98.28%   -0.03%     
==========================================
  Files          74       74              
  Lines        8038     8043       +5     
==========================================
+ Hits         7902     7905       +3     
- Misses        136      138       +2     
Flag Coverage Δ
unittests 98.28% <92.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
rich/_export_format.py 100.00% <ø> (ø)
rich/align.py 100.00% <ø> (ø)
rich/console.py 98.04% <100.00%> (+<0.01%) ⬆️
rich/containers.py 100.00% <ø> (ø)
rich/markdown.py 99.45% <100.00%> (ø)
rich/markup.py 100.00% <ø> (ø)
rich/panel.py 98.29% <ø> (ø)
rich/progress.py 92.92% <ø> (ø)
rich/syntax.py 98.19% <100.00%> (-0.29%) ⬇️
rich/text.py 99.00% <66.66%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darrenburns darrenburns merged commit 92e7164 into Textualize:master Nov 7, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants