Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double-width characters disappearing when wrapping #3180

Merged
merged 22 commits into from
Nov 14, 2023
Merged

Fix double-width characters disappearing when wrapping #3180

merged 22 commits into from
Nov 14, 2023

Commits on May 31, 2023

  1. Merge branch 'master' of github.com:Textualize/rich

    @darrenburns
    darrenburns committed May 31, 2023
    Configuration menu
    Copy the full SHA
    01d787b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge remote-tracking branch 'origin/master'

    @darrenburns
    darrenburns committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    8fb36b0 View commit details
    Browse the repository at this point in the history

  2. Update docstring for Text.wraps width parameter to indicate that it… 

    …'s referring to the number of *single-width* characters.

Also a small addition to the gitignore file.
    @darrenburns
    darrenburns committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c8e478e View commit details
    Browse the repository at this point in the history

  3. Working on double width wrapping fixes

    @darrenburns
    darrenburns committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f7d2a1a View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Chop cells to fit to width

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    70ce4db View commit details
    Browse the repository at this point in the history

  2. Fix folding when theres already text on line

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    85d89d0 View commit details
    Browse the repository at this point in the history

  3. Update wrapping logic to fix issues with CJK charcters disappearing w… 

    …hen the "fold" location sat *within* a double-width character. Ensure we retain browser logic of: if there is no space on the current line, move to a new line, and if theres not enough space on the entire new line, fold the text over multiple lines at appropriate locations.
    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9f93126 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:willmcgugan/rich into double-widt… 

    …h-wrapping-fix
    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    4217cd3 View commit details
    Browse the repository at this point in the history

  5. Remove old TODO comments

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    4555def View commit details
    Browse the repository at this point in the history

  6. Add regression test note

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8d6507b View commit details
    Browse the repository at this point in the history

  7. Rename function to avoid breaking change

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8007cd3 View commit details
    Browse the repository at this point in the history

  8. Update CHANGELOG

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f1cc1d9 View commit details
    Browse the repository at this point in the history

  9. Remove old comment that is no longer relevant

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9eed638 View commit details
    Browse the repository at this point in the history

  10. Cover off some wrapping edge cases

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    df877f2 View commit details
    Browse the repository at this point in the history

  11. Adding docstrings to tests explaining their purpose

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    0ab4732 View commit details
    Browse the repository at this point in the history

  12. Renaming a local, function scope function alias

    @darrenburns
    darrenburns committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2053eb0 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Update rich/_wrap.py 

    Co-authored-by: Rodrigo Girão Serrão <[email protected]>
    @darrenburns @rodrigogiraoserrao
    darrenburns and rodrigogiraoserrao authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    077ef44 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. PR feedback

    @darrenburns
    darrenburns committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    0280567 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'double-width-wrapping-fix' of github.com:willmcgugan/ri… 

    …ch into double-width-wrapping-fix
    @darrenburns
    darrenburns committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    3863739 View commit details
    Browse the repository at this point in the history

  3. Testing wrapping with trailing and leading whitespace

    @darrenburns
    darrenburns committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    55972a9 View commit details
    Browse the repository at this point in the history

  4. Improve docstring wording

    @darrenburns
    darrenburns committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f82b464 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into double-width-wrapping-fix

    @darrenburns
    darrenburns authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    05c5dfc View commit details
    Browse the repository at this point in the history