Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): add support for using asyncio.Task as an alternative to threading.Thread to handle live updates #3457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dominik-schwabe
Copy link

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

This pull request adds support for using asyncio.Task as an alternative to threading.Thread to handle live updates.
The main reason for implementing this is that when using __import__('pdb').set_trace() or something similar, the screen keeps getting updated making it impossible to debug. Since __import__('pdb').set_trace() interrupts the event loop, this problem wont happen when using async code to handle the updates. Additionally it seams natural to use the event loop to handle the updates when one is available.
I set the default to determining the refresh method to "auto", which determines the method based on if there is a running event loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant