Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex error #3535

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Regex error #3535

merged 7 commits into from
Oct 22, 2024

Conversation

willmcgugan
Copy link
Collaborator

Fixes an issue with the regex used to select the fast path for strings with single-width characters.

This may have had a detrimental effect on performance for some operations.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (9c74f03) to head (60f3b61).
Report is 102 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3535      +/-   ##
==========================================
+ Coverage   98.25%   98.27%   +0.01%     
==========================================
  Files          74       74              
  Lines        8072     8096      +24     
==========================================
+ Hits         7931     7956      +25     
+ Misses        141      140       -1     
Flag Coverage Δ
unittests 98.27% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomJGooding
Copy link
Contributor

TomJGooding commented Oct 22, 2024

Sorry looks like you beat me to it!

Just to check, did you mean to include \u007F (DEL)?

@willmcgugan willmcgugan merged commit afcc5c5 into master Oct 22, 2024
21 checks passed
@willmcgugan willmcgugan deleted the regex-error branch October 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants